Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169 Deserialize kebab-case #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

esotery
Copy link

@esotery esotery commented Sep 26, 2017

Hi there,

fixed the issue. All unit tests are passing. I have added mine and verified the functionality but haven't actually pushed it in because the data and structure is kinda proprietary.

@joukevandermaas
Copy link
Owner

Thanks so much for contributing!

I think it would be nice to have one small unit test that verifies the new behavior, so we prevent regressions in the future. There should already be some models you can use in the Tests project.

@PhyberApex
Copy link
Contributor

I was just checking this PR to implement the missing unit test. Could it be that you already fixed this in another commit? Because the edited files in this PR are now using the propertyNameConverter already.

~Cheers

@joukevandermaas
Copy link
Owner

@PhyberApex yes, i seem to recall fixing this when I was writing some extra tests. I had forgotten about this PR so I didn't post a comment. Are you able to see if #169 is fixed for you in the latest pre-release?

@PhyberApex
Copy link
Contributor

PhyberApex commented Sep 21, 2018

Right now I am not able to check this. But if you want me to, I can give it a go on monday and report back!

~Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants